Github user lresende commented on a diff in the pull request:
https://github.com/apache/bahir/pull/43#discussion_r117160442
--- Diff:
streaming-twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterInputDStream.scala
---
@@ -85,10 +85,8 @@ class TwitterReceiver(
}
})
- val query = new FilterQuery
- if (filters.size > 0) {
- query.track(filters.mkString(","))
- newTwitterStream.filter(query)
+ if (query.isDefined) {
+ newTwitterStream.filter(query.get)
} else {
--- End diff --
It looks like the query option was being available as a seq of string,
which then was converted to FilterQuery, and doing so we were hiding the
implementation detail specific interface from the user. What were the
limitations of using that strategy ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
