Github user ricellis commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/45#discussion_r126435531
  
    --- Diff: 
sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantReceiver.scala ---
    @@ -16,23 +16,20 @@
      */
     package org.apache.bahir.cloudant
     
    -// scalastyle:off
    -import scalaj.http._
    -
     import play.api.libs.json.Json
    +import scalaj.http._
     
    +import org.apache.spark.SparkConf
     import org.apache.spark.storage.StorageLevel
     import org.apache.spark.streaming.receiver.Receiver
    -import org.apache.spark.SparkConf
     
     import org.apache.bahir.cloudant.common._
    -// scalastyle:on
     
     class CloudantReceiver(sparkConf: SparkConf, cloudantParams: Map[String, 
String])
         extends Receiver[String](StorageLevel.MEMORY_AND_DISK) {
    -  lazy val config: CloudantConfig = {
    +  lazy val config: CloudantChangesConfig = {
    --- End diff --
    
    Would this class be better named `CloudantChangesReceiver`? Since it 
doesn't appear to be a general case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to