[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

[ricellis]

Github user ricellis commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/57#discussion_r157484722
  
    --- Diff: 
sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala
 ---
    @@ -39,56 +37,38 @@ class ChangesReceiver(config: CloudantChangesConfig)
       }
     
       private def receive(): Unit = {
    -    // Get total number of docs in database using _all_docs endpoint
    -    val limit = new JsonStoreDataAccess(config)
    -      .getTotalRows(config.getTotalUrl, queryUsed = false)
    -
    -    // Get continuous _changes url
    +    // Get normal _changes url
    --- End diff --
    
    I'm a bit confused about this change. Since Spark Streaming is the basis 
for "real-time" or "continuous applications" doesn't this need to keep 
listening to the changes feed to wait for more changes?


---