Github user lukasz-antoniak commented on the issue:

    https://github.com/apache/bahir/pull/53
  
    @ankitagr2312: Since the last update is already one year old, do you plan to
    work on this JIRA ticket and pull request? If not, do you agree that I take 
it from here?
    
    1) I think that `ServiceAccountCredentials` could be divided into two 
separate implementations of `SparkGPCCredentials` interface. First 
implementation `JsonConfigCredentials` would accept either path to JSON file or 
binary content. Second implementation `EmailPrivateKeyCredentials` would 
require passing email address and path to P12 key or binary content of the key.
    
    2) Can you revert to original formatting of lines that you did not mean to 
modify?
    
    3) Update the _README.md_ to include new feature? Undocumented feature is 
not a feature :).


---

Reply via email to