eskabetxe commented on a change in pull request #57: [BAHIR-205] Support
configure password for redis cluster
URL: https://github.com/apache/bahir-flink/pull/57#discussion_r291568219
##########
File path:
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfigTest.java
##########
@@ -46,4 +48,20 @@ public void
shouldThrowIllegalArgumentExceptionIfNodeValuesAreEmpty(){
.setNodes(set)
.build();
}
+
+ @Test
+ public void shouldSetPasswordSuccessfully() {
Review comment:
could you add a test with no password setted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
