gyfora commented on a change in pull request #78: Kudu Connector rework URL: https://github.com/apache/bahir-flink/pull/78#discussion_r410406016
########## File path: flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/KuduTableFactory.java ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.kudu.table; + +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.connectors.kudu.connector.KuduTableInfo; +import org.apache.flink.connectors.kudu.connector.reader.KuduReaderConfig; +import org.apache.flink.connectors.kudu.connector.writer.KuduWriterConfig; +import org.apache.flink.connectors.kudu.table.utils.KuduTableUtils; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.catalog.CatalogTable; +import org.apache.flink.table.catalog.ObjectPath; +import org.apache.flink.table.descriptors.DescriptorProperties; +import org.apache.flink.table.descriptors.SchemaValidator; +import org.apache.flink.table.factories.TableSinkFactory; +import org.apache.flink.table.factories.TableSourceFactory; +import org.apache.flink.table.utils.TableSchemaUtils; +import org.apache.flink.types.Row; +import static org.apache.flink.util.Preconditions.checkNotNull; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.apache.flink.table.descriptors.ConnectorDescriptorValidator.CONNECTOR_TYPE; +import static org.apache.flink.table.descriptors.DescriptorProperties.TABLE_SCHEMA_EXPR; +import static org.apache.flink.table.descriptors.DescriptorProperties.WATERMARK; +import static org.apache.flink.table.descriptors.DescriptorProperties.WATERMARK_ROWTIME; +import static org.apache.flink.table.descriptors.DescriptorProperties.WATERMARK_STRATEGY_DATA_TYPE; +import static org.apache.flink.table.descriptors.DescriptorProperties.WATERMARK_STRATEGY_EXPR; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_TIMESTAMPS_CLASS; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_TIMESTAMPS_FROM; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_TIMESTAMPS_SERIALIZED; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_TIMESTAMPS_TYPE; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_WATERMARKS_CLASS; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_WATERMARKS_DELAY; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_WATERMARKS_SERIALIZED; +import static org.apache.flink.table.descriptors.Rowtime.ROWTIME_WATERMARKS_TYPE; +import static org.apache.flink.table.descriptors.Schema.SCHEMA; +import static org.apache.flink.table.descriptors.Schema.SCHEMA_DATA_TYPE; +import static org.apache.flink.table.descriptors.Schema.SCHEMA_FROM; +import static org.apache.flink.table.descriptors.Schema.SCHEMA_NAME; +import static org.apache.flink.table.descriptors.Schema.SCHEMA_PROCTIME; +import static org.apache.flink.table.descriptors.Schema.SCHEMA_TYPE; + +public class KuduTableFactory implements TableSourceFactory<Row>, TableSinkFactory<Tuple2<Boolean, Row>> { + + public static final String KUDU_TABLE = "kudu.table"; + public static final String KUDU_MASTERS = "kudu.masters"; + public static final String KUDU_HASH_COLS = "kudu.hash-columns"; + public static final String KUDU_PRIMARY_KEY_COLS = "kudu.primary-key-columns"; + public static final String KUDU_REPLICAS = "kudu.replicas"; + public static final String KUDU = "kudu"; + + @Override + public Map<String, String> requiredContext() { + Map<String, String> context = new HashMap<>(); + context.put(CONNECTOR_TYPE, KUDU); + return context; + } + + @Override + public List<String> supportedProperties() { + List<String> properties = new ArrayList<>(); + properties.add(KUDU_TABLE); + properties.add(KUDU_MASTERS); + properties.add(KUDU_HASH_COLS); + properties.add(KUDU_PRIMARY_KEY_COLS); + // schema + properties.add(SCHEMA + ".#." + SCHEMA_DATA_TYPE); + properties.add(SCHEMA + ".#." + SCHEMA_TYPE); + properties.add(SCHEMA + ".#." + SCHEMA_NAME); + properties.add(SCHEMA + ".#." + SCHEMA_FROM); + // computed column + properties.add(SCHEMA + ".#." + TABLE_SCHEMA_EXPR); + + // time attributes + properties.add(SCHEMA + ".#." + SCHEMA_PROCTIME); + properties.add(SCHEMA + ".#." + ROWTIME_TIMESTAMPS_TYPE); + properties.add(SCHEMA + ".#." + ROWTIME_TIMESTAMPS_FROM); + properties.add(SCHEMA + ".#." + ROWTIME_TIMESTAMPS_CLASS); + properties.add(SCHEMA + ".#." + ROWTIME_TIMESTAMPS_SERIALIZED); + properties.add(SCHEMA + ".#." + ROWTIME_WATERMARKS_TYPE); + properties.add(SCHEMA + ".#." + ROWTIME_WATERMARKS_CLASS); + properties.add(SCHEMA + ".#." + ROWTIME_WATERMARKS_SERIALIZED); + properties.add(SCHEMA + ".#." + ROWTIME_WATERMARKS_DELAY); + + // watermark + properties.add(SCHEMA + "." + WATERMARK + ".#." + WATERMARK_ROWTIME); + properties.add(SCHEMA + "." + WATERMARK + ".#." + WATERMARK_STRATEGY_EXPR); + properties.add(SCHEMA + "." + WATERMARK + ".#." + WATERMARK_STRATEGY_DATA_TYPE); + return properties; + } + + private DescriptorProperties getValidatedProps(Map<String, String> properties) { + checkNotNull(properties.get(KUDU_MASTERS), "Missing required property " + KUDU_MASTERS); Review comment: The KuduCatalog basically provides the default for this. So as long as you use the KuduCatalog (and specified the masters there) you wouldnt have to specify it for individual tables. On the other hand when you are creating Kudu tables in other catalogs you will end up in this codepath and you have to specify the kudu masters ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
