lresende commented on a change in pull request #99:
URL: https://github.com/apache/bahir/pull/99#discussion_r457486342
##########
File path:
sql-streaming-sqs/src/main/scala/org/apache/spark/sql/streaming/sqs/SqsClient.scala
##########
@@ -220,11 +220,12 @@ class SqsClient(sourceOptions: SqsSourceOptions,
.standard()
.withClientConfiguration(new
ClientConfiguration().withMaxConnections(maxConnections))
.withCredentials(instanceProfileCredentialsProvider)
+ .withRegion(region)
.build()
}
} catch {
case e: Exception =>
- throw new SparkException(s"Error occured while creating Amazon SQS
Client ${e.getMessage}")
+ throw new SparkException(s"Error occured while creating Amazon SQS
Client", e)
Review comment:
Adding the message is good, but did you intended to remove the "cause"
on the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
