DmitryGrb commented on a change in pull request #97:
URL: https://github.com/apache/bahir/pull/97#discussion_r458672251
##########
File path: sql-streaming-sqs/README.md
##########
@@ -63,6 +63,7 @@ shouldSortFiles|true|whether to sort files based on timestamp
while listing them
useInstanceProfileCredentials|false|Whether to use EC2 instance profile
credentials for connecting to Amazon SQS
maxFilesPerTrigger|no default value|maximum number of files to process in a
microbatch
maxFileAge|7d|Maximum age of a file that can be found in this directory
+messageWrapper|None|'None' if SQS contains plain S3 message. 'SNS' if SQS
contains S3 notification message which came from SNS
Review comment:
Done. Added small section which describes differences in SQS vs SNS
approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
