eskabetxe commented on a change in pull request #99:
URL: https://github.com/apache/bahir-flink/pull/99#discussion_r492238308
##########
File path: .travis.yml
##########
@@ -34,8 +34,8 @@ jdk:
- openjdk8
env:
- - FLINK_VERSION="1.10.0" SCALA_VERSION="2.11"
- - FLINK_VERSION="1.10.0" SCALA_VERSION="2.12"
+ - FLINK_VERSION="1.11.1" SCALA_VERSION="2.11"
Review comment:
could you change to same version of pom (1.11.2)
##########
File path: flink-connector-flume/pom.xml
##########
@@ -53,13 +53,20 @@ under the License.
<version>${flume-ng.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-tests</artifactId>
- <version>${flink.version}</version>
- <type>test-jar</type>
- <scope>test</scope>
- </dependency>
+ <dependency>
Review comment:
could you fix identation
##########
File path: flink-connector-flume/pom.xml
##########
@@ -53,13 +53,20 @@ under the License.
<version>${flume-ng.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-tests</artifactId>
- <version>${flink.version}</version>
- <type>test-jar</type>
- <scope>test</scope>
- </dependency>
+ <dependency>
Review comment:
could you fix indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
