eskabetxe commented on a change in pull request #103:
URL: https://github.com/apache/bahir-flink/pull/103#discussion_r558002712
##########
File path:
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/table/utils/KuduTableUtils.java
##########
@@ -78,11 +79,20 @@ public static KuduTableInfo createTableInfo(String
tableName, TableSchema schema
List<String> keyColumns = getPrimaryKeyColumns(props, schema);
ColumnSchemasFactory schemasFactory = () ->
toKuduConnectorColumns(columns, keyColumns);
List<String> hashColumns = getHashColumns(props);
- int replicas =
Optional.ofNullable(props.get(KuduTableFactory.KUDU_REPLICAS)).map(Integer::parseInt).orElse(1);
+ int replicas =
Optional.ofNullable(props.get(KuduTableFactory.KUDU_REPLICAS)).map(Integer::parseInt).orElse(3);
Review comment:
why are we changing the default number of replicas from 1 to 3 ?
##########
File path:
flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/table/NewTablePropertiesTest.java
##########
@@ -0,0 +1,44 @@
+package org.apache.flink.connectors.kudu.table;
+
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.bridge.java.StreamTableEnvironment;
+import org.apache.flink.table.catalog.ObjectPath;
+import org.apache.flink.table.catalog.exceptions.TableNotExistException;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+/**
Review comment:
could you remove this type of javadoc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
