ahern88 commented on a change in pull request #101:
URL: https://github.com/apache/bahir-flink/pull/101#discussion_r558203282
##########
File path:
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/handler/FlinkJedisClusterConfigHandler.java
##########
@@ -44,8 +45,16 @@ public FlinkJedisConfigBase
createFlinkJedisConfig(Map<String, String> propertie
String[] arr = r.split(":");
return new InetSocketAddress(arr[0].trim(),
Integer.parseInt(arr[1].trim()));
}).collect(Collectors.toSet());
- return new FlinkJedisClusterConfig.Builder()
- .setNodes(nodes).build();
+ String clusterPassword =
properties.getOrDefault(REDIS_CLUSTER_PASSWORD, null);
+ if (clusterPassword != null && clusterPassword.trim().isEmpty()) {
Review comment:
Thanks, i optimized the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
