fapaul commented on a change in pull request #113:
URL: https://github.com/apache/bahir-flink/pull/113#discussion_r598080032
##########
File path:
flink-connector-pinot/src/test/java/org/apache/flink/streaming/connectors/pinot/PinotTestBase.java
##########
@@ -85,6 +92,35 @@
.withStartupTimeout(Duration.ofSeconds(180))
);
+ @ClassRule
Review comment:
You can either remove the `@ClassRule` or, my preference, use
https://github.com/apache/flink/blob/master/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterWithClientResource.java.
Currently the `@ClassRule` has no effect because the `MiniCluster` does not
implement the required interfaces therefore you have to call `@BeforeAll` and
`@AfterAll` manually.
##########
File path:
flink-connector-pinot/src/test/java/org/apache/flink/streaming/connectors/pinot/PinotTestBase.java
##########
@@ -85,6 +92,35 @@
.withStartupTimeout(Duration.ofSeconds(180))
);
+ @ClassRule
+ public static final MiniCluster MINI_CLUSTER = new MiniCluster(
Review comment:
Either remove the `@ClassRule` or, my preference, use
https://github.com/apache/flink/blob/master/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterWithClientResource.java.
Currently the `@ClassRule` has no effect because the `MiniCluster` does not
implement the required interfaces therefore you have to call `@BeforeAll` and
`@AfterAll` manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
