eskabetxe commented on a change in pull request #136:
URL: https://github.com/apache/bahir-flink/pull/136#discussion_r773328460
##########
File path:
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/RedisSinkZIncrByTest.java
##########
@@ -1,121 +0,0 @@
-/*
Review comment:
why we delete this test?
##########
File path: flink-connector-flume/pom.xml
##########
@@ -36,7 +36,7 @@ under the License.
<!-- Allow users to pass custom connector versions -->
<properties>
<flume-ng.version>1.9.0</flume-ng.version>
- <testcontainers.version>1.15.3</testcontainers.version>
+ <testcontainers.version>1.16.2</testcontainers.version>
Review comment:
is this mandatory for flink update?
if not will be better in other commit, only with this update (and related)
##########
File path: flink-connector-activemq/pom.xml
##########
@@ -101,14 +101,14 @@ under the License.
<dependency>
<groupId>org.powermock</groupId>
<artifactId>powermock-module-junit4</artifactId>
- <version>1.5.5</version>
+ <version>2.0.9</version>
Review comment:
is this mandatory for flink update?
if not will be better in other commit, only for powermock update (and
related)
##########
File path: flink-connector-influxdb2/pom.xml
##########
@@ -39,7 +39,7 @@ under the License.
<influxdbClient.version>2.0.0</influxdbClient.version>
<druid.version>0.13.0-incubating</druid.version>
<!-- Test Properties -->
- <testcontainers.version>1.15.2</testcontainers.version>
+ <testcontainers.version>1.16.2</testcontainers.version>
Review comment:
is this mandatory for flink update?
if not will be better in other commit, only with this update (and related)
##########
File path:
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisDescriptorTest.java
##########
@@ -51,23 +46,26 @@ public void testRedisDescriptor() throws Exception {
EnvironmentSettings settings = EnvironmentSettings
.newInstance()
- .useOldPlanner()
.inStreamingMode()
.build();
StreamTableEnvironment tableEnvironment =
StreamTableEnvironment.create(env, settings);
tableEnvironment.registerDataStream("t1", source, "k, v");
- Redis redis = new Redis()
+ /*Redis redis = new Redis()
Review comment:
this comment could be removed no?
##########
File path: flink-connector-redis/pom.xml
##########
@@ -34,7 +34,7 @@ under the License.
<packaging>jar</packaging>
<properties>
- <jedis.version>2.9.0</jedis.version>
+ <jedis.version>3.7.1</jedis.version>
Review comment:
is this mandatory for flink update?
if not will be better in other commit, only with this update (and related)
##########
File path: flink-connector-activemq/pom.xml
##########
@@ -35,7 +35,7 @@ under the License.
<!-- Allow users to pass custom connector versions -->
<properties>
- <activemq.version>5.15.10</activemq.version>
+ <activemq.version>5.16.2</activemq.version>
Review comment:
is this mandatory for flink update?
if not will be better in other commit, only with this update (and related)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
