eskabetxe commented on code in PR #156:
URL: https://github.com/apache/bahir-flink/pull/156#discussion_r991455017
##########
flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java:
##########
@@ -46,15 +46,7 @@ public RedisClusterContainer(JedisCluster jedisCluster) {
this.jedisCluster = jedisCluster;
}
- @Override
- public void open() throws Exception {
-
- // echo() tries to open a connection and echos back the
- // message passed as argument. Here we use it to monitor
- // if we can communicate with the cluster.
-
- jedisCluster.echo("Test");
- }
+ public void open() {}
Review Comment:
@srmrz "jedisCluster.echo("Test");"
I don't know if is needed.. but for the comment its testing the
communication with cluster..
I don't write this code, I'm trying to understand if removing that code
could have some side effect..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
