eskabetxe commented on code in PR #155:
URL: https://github.com/apache/bahir-flink/pull/155#discussion_r995791649


##########
flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java:
##########
@@ -78,7 +79,25 @@ public void testRedisClusterDownBehavior() throws Exception {
             .setMaxTotal(1)
             .setMinIdle(1).build();
 
-        testDownBehavior(wrongJedisClusterConfig);
+        RedisSink<Tuple2<String, String>> redisSink = new 
RedisSink<>(wrongJedisClusterConfig,

Review Comment:
   I think we can change the exception from testDownBehavior to JedisException 
with our a problem..
   or put the 2 exceptions on condition..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to