thebalu commented on code in PR #161:
URL: https://github.com/apache/bahir-flink/pull/161#discussion_r1062304376
##########
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/KuduFilterInfo.java:
##########
@@ -65,7 +65,7 @@ private KuduPredicate predicateComparator(ColumnSchema
column) {
switch (column.getType()) {
case STRING:
- predicate = KuduPredicate.newComparisonPredicate(column,
comparison, (String) this.value);
+ predicate = KuduPredicate.newComparisonPredicate(column,
comparison, String.valueOf(this.value));
Review Comment:
Good point, I've updated it as suggested.
I'm not sure if such a case is possible, as there is some type checking done
at earlier points as well, so only String-like types will be able to get to
this point; but I haven't looked too much into it yet. So I agree that the
minimal change is the safer/better solution here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
