eskabetxe commented on PR #166: URL: https://github.com/apache/bahir-flink/pull/166#issuecomment-1567943714
> > Hi @collabH, > > could we have a test for this? > > https://github.com/apache/bahir-flink/blob/176242c9d10d8a67a0f773dc61235b96b26e3c44/flink-connector-kudu/src/test/java/org/apache/flink/connectors/kudu/format/KuduRowDataInputFormatTest.java#L63 > > Please see KuduRowDataInputFormatTest#testInputFormatWithProjection method, this part has been covered but that test dont check that connections are closed no? that is the problem you are trying to solve with this PR.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@bahir.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
