jiajunwang commented on a change in pull request #381: Implement the POC work
greedy constraint based algorithm
URL: https://github.com/apache/helix/pull/381#discussion_r311765021
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java
##########
@@ -103,7 +103,7 @@ private void refresh(ClusterConfig clusterConfig,
InstanceConfig instanceConfig,
*
* @param assignableReplica - the replica to be assigned
*/
- void assign(AssignableReplica assignableReplica) {
+ public void assign(AssignableReplica assignableReplica) {
Review comment:
Please don't make these methods public. They were designed to be
package-private intentionally. The idea is that all the update to the
assignment shall be done through ClusterModel interfaces. It will be much
easier to ensure the model is consistent.
If you make assign/release public here, what if the caller call the node
assign but does not call the context addPartitionToFaultZone? The cluster model
will be in a inconsistent state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
