narendly commented on a change in pull request #410: Fix the execution delay
for the jobs (409)
URL: https://github.com/apache/helix/pull/410#discussion_r314177297
##########
File path:
helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
##########
@@ -165,7 +165,9 @@ public void updateWorkflowStatus(String workflow,
WorkflowConfig workflowCfg,
RuntimeJobDag runtimeJobDag =
_clusterDataCache.getTaskDataCache().getRuntimeJobDag(workflow);
if (runtimeJobDag != null) {
for (String inflightJob : runtimeJobDag.getInflightJobList()) {
- processJob(inflightJob, currentStateOutput, bestPossibleOutput,
workflowCtx);
+ if (System.currentTimeMillis() >=
workflowCtx.getJobStartTime(inflightJob)) {
Review comment:
For the execution delay itself, adding this check may do the trick. However,
two more things to consider:
1. Would this be the right place to place the check? Say, should we include
this check inside processJob()? Or should we create a separate method that
checks whether a job is eligible to be processed?
2. Could there be more checks we need to perform other than execution delay?
It would be great if we could make this a comprehensive fix :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
