jiajunwang commented on issue #378: Make the reservoir used in 
ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-521818405
 
 
   > @chenboat @narendly I'm thinking about if there is a better way to test.
   > 
   > My major concern is that we make the protected method public just for 
testing.
   > Moreover, it seems we can only verify if the system property is read 
correctly. We cannot verify if it has been applied to the Histogram as 
expected. The window field is private in the metrics lib. I haven't got a good 
idea now : (
   
   I got something. It could be a bad idea, but better than nothing.
   Can we add a test case that:
   1. set the time window to 2 seconds.
   2. create a monitor and update a histogram metric data once. Verify the 
expected data presents in the histogram metric.
   3. Wait for 3 seconds. Check the same histogram metric data, the data should 
be have been reset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to