jiajunwang commented on a change in pull request #413: Add cluster level default instance config. URL: https://github.com/apache/helix/pull/413#discussion_r314872913
########## File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestAssignableNode.java ########## @@ -200,4 +200,17 @@ public void testParseFaultZone() throws IOException { Assert.assertEquals(assignableNode.getFaultZone(), "2/testInstance/"); } + + @Test + public void testDefaultInstanceCapacity() { + ClusterConfig testClusterConfig = new ClusterConfig("testClusterConfigId"); + testClusterConfig.setDefaultInstanceCapacityMap(_capacityDataMap); + + InstanceConfig testInstanceConfig = new InstanceConfig("testInstanceConfigId"); + + AssignableNode assignableNode = + new AssignableNode(testClusterConfig, testInstanceConfig, _testInstanceId, + Collections.emptyList()); + Assert.assertEquals(assignableNode.getMaxCapacity(), _capacityDataMap); Review comment: The test for verifying default capacity in the Cluster Config has been done in the TestClusterConfig. For the test here, the instance capacity is applied to the assignable node "maxCapacity" field ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org