pkuwm opened a new pull request #470: Fix helix-front build failure by downgrading types/lodash version. URL: https://github.com/apache/helix/pull/470 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: https://github.com/apache/helix/issues/469 Building helix-front is failed because node_modules/@types/lodash/common/collection.d.ts(1783,24): error TS2304: Cannot find name 'Exclude'. ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: (Write a concise description including what, why, how) types/lodash module uses the latest release 4.14.138 which doesn't have "Exclude". Downgrading the module version is the solution. ### Tests - [] The following tests are written for this issue: (List the names of added unit/integration tests) - [] The following is the result of the "mvn test" command on the appropriate module: (Copy & paste the result of "mvn test") ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message": Subject is separated from body by a blank line Subject is limited to 50 characters (not including Jira issue reference) Subject does not end with a period Subject uses the imperative mood ("add", not "adding") Body wraps at 72 characters Body explains "what" and "why", not "how" Documentation In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
