narendly commented on a change in pull request #490: Add latency metric components for WAGED rebalancer URL: https://github.com/apache/helix/pull/490#discussion_r330829643
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/metrics/WagedRebalancerMetricCollector.java ########## @@ -0,0 +1,76 @@ +package org.apache.helix.controller.rebalancer.waged.metrics; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.google.common.annotations.VisibleForTesting; +import javax.management.JMException; +import org.apache.helix.controller.rebalancer.waged.metrics.implementation.RebalanceLatencyGauge; +import org.apache.helix.controller.rebalancer.waged.metrics.model.LatencyMetric; + +public class WagedRebalancerMetricCollector extends MetricCollector { + private static final String WAGED_REBALANCER_ENTITY_NAME = "WagedRebalancer"; + + /** + * This enum class contains all metric names defined for WagedRebalancer. Note that all enums are + * in camel case for readability. + */ + public enum WagedRebalancerMetricNames { + // Per-stage latency metrics + GlobalBaselineCalcLatencyGauge, + PartialRebalanceLatencyGauge, + + // The following latency metrics are related to AssignmentMetadataStore + StateReadLatencyGauge, + StateWriteLatencyGauge + } + + public WagedRebalancerMetricCollector(String clusterName) throws JMException { + super(clusterName, WAGED_REBALANCER_ENTITY_NAME); + createMetrics(); + register(); + } + + @VisibleForTesting + public WagedRebalancerMetricCollector() throws JMException { Review comment: Comment added. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
