dasahcc commented on a change in pull request #504: Fix null response for
instance stoppable check when connection refused.
URL: https://github.com/apache/helix/pull/504#discussion_r331633590
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -220,6 +222,12 @@ private StoppableCheck performCustomInstanceCheck(String
clusterId, String insta
return new StoppableCheck(
_customRestClient.getInstanceStoppableCheck(baseUrl, customPayLoads),
StoppableCheck.Category.CUSTOM_INSTANCE_CHECK);
+ } catch (HttpHostConnectException ex) {
+ String msg = "Custom client side instance level health check for {}/{}
failed "
+ + "because of connection refused.";
+ LOG.error(msg, clusterId, instanceName, ex);
+ return new StoppableCheck(false, Arrays.asList(instanceName),
+ StoppableCheck.Category.CUSTOM_INSTANCE_CHECK);
} catch (IOException e) {
Review comment:
I remember you said connection exception is part of IOException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
