narendly commented on a change in pull request #510: Fixing rebalance cache
issue and stablize the tests.
URL: https://github.com/apache/helix/pull/510#discussion_r334200103
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
##########
@@ -124,7 +124,8 @@ public synchronized void refresh(HelixDataAccessor
accessor) {
if (changedTypes.contains(HelixConstants.ChangeType.IDEAL_STATE)
|| changedTypes.contains(HelixConstants.ChangeType.LIVE_INSTANCE)
|| changedTypes.contains(HelixConstants.ChangeType.INSTANCE_CONFIG)
- || changedTypes.contains(HelixConstants.ChangeType.RESOURCE_CONFIG)) {
+ || changedTypes.contains(HelixConstants.ChangeType.RESOURCE_CONFIG)
+ || changedTypes.contains((HelixConstants.ChangeType.CLUSTER_CONFIG))) {
Review comment:
I suggest double-checking this. Sometimes in the pipeline we just use
ChangeType.CONFIG. I can't quite recall where.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
