jiajunwang commented on issue #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#issuecomment-543267517 > Suggestion on the description of the PR. You say "a more strict check", but you don't actually describe it. So the reviewer has no clue what the "more strict check" should be. I think if you could actually describe it, something like, "previously, if a resource's weight is not set, we consider it 0. But we will change that behavior so that if a resource's weight is not set, we will throw an exception and halt the rebalancing." > Then the reviewer knows what to watch out for and whether the code change actually reflects that change. Sure. Updated the description.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
