narendly commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337322377
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -174,9 +174,34 @@ public void close() {
LOG.info("Start computing new ideal states for resources: {}",
resourceMap.keySet().toString());
validateInput(clusterData, resourceMap);
- // Calculate the target assignment based on the current cluster status.
- Map<String, IdealState> newIdealStates =
- computeBestPossibleStates(clusterData, resourceMap,
currentStateOutput);
+ Map<String, IdealState> newIdealStates;
+ try {
+ // Calculate the target assignment based on the current cluster status.
+ newIdealStates = computeBestPossibleStates(clusterData, resourceMap,
currentStateOutput);
+ } catch (HelixRebalanceException ex) {
+ LOG.error("The new assignment calculation fails.", ex);
Review comment:
Then you could say "Failed to calculate the new assignments." Let's make it
consistent with other logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
