jiajunwang opened a new pull request #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #518 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Refine the rebalance scope calculating logic in the WAGED rebalancer. 1. Ignore the IdealState mapping/listing fields if the resource is in FULL_AUTO mode. 2. On IdealState change, the resource shall be fully rebalanced since some filter conditions might be changed. Such as instance tag. 3. Live instance change (node newly connected) shall trigger full rebalance so partitions will be re-assigned to the new node. 4. Modify the related test cases. ### Tests - [ ] The following tests are written for this issue: The changed logic is covered by existing tests. - [ ] The following is the result of the "mvn test" command on the appropriate module: [ERROR] Failures: [ERROR] TestTaskPerformanceMetrics.testTaskPerformanceMetrics:118 expected:<true> but was:<false> [ERROR] TestGetLastScheduledTaskExecInfo.testGetLastScheduledTaskExecInfo:73 expected:<COMPLETED> but was:<RUNNING> [INFO] [ERROR] Tests run: 1042, Failures: 2, Errors: 0, Skipped: 3 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ Rerun and these 2 tests pass. ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: NA ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
