pkuwm opened a new issue #521: Upgrade testng to fix unit test bugs URL: https://github.com/apache/helix/issues/521 Found a bug for assertEquals(map1, map2). When map1 is empty and map2 is not, assertEquals(map1, map2) could pass, which is supposed to fail. Current testng version is way too old: 6.0.1, which was released in Mar 24, 2011. The latest release version is 7.0.0 Aug 18, 2019. I've verified 7.0.0 doesn't that the bug. We should upgrade testng to this version and fix at least the bug above.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
