jiajunwang commented on a change in pull request #514: The WAGED rebalancer
returns the previously calculated assignment on calculation failure
URL: https://github.com/apache/helix/pull/514#discussion_r337713013
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/rebalancer/WagedRebalancer/TestWagedRebalance.java
##########
@@ -354,12 +354,12 @@ public void testMaxPartitionLimitation() throws
Exception {
String limitedResourceName = null;
int i = 0;
for (String stateModel : _testModels) {
- String db = "Test-DB-" + i++;
+ String db = "Test-DB-testMaxPartitionLimitation-" + i++;
createResourceWithWagedRebalance(CLUSTER_NAME, db, stateModel,
PARTITIONS, _replica,
_replica);
if (i == 1) {
// The limited resource has additional limitation, so even the other
resources can be assigned
- // later, this resource will still be blocked by the max partition
limitation.
+ // later in theory, this resource will still be blocked by the max
partition limitation.
Review comment:
Let me refine the comments.
This is special for the WAGED rebalancer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
