narendly commented on a change in pull request #517: Add typoed name
DataPropagationLatencyGuage as deprecated
URL: https://github.com/apache/helix/pull/517#discussion_r337793818
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ZkClientPathMonitor.java
##########
@@ -143,6 +150,10 @@ public ZkClientPathMonitor(PredefinedPath path, String
monitorType, String monit
new
HistogramDynamicMetric(PredefinedMetricDomains.DataPropagationLatencyGauge.name(),
new Histogram(new
SlidingTimeWindowArrayReservoir(getResetIntervalInMs(),
TimeUnit.MILLISECONDS)));
+ _dataPropagationLatencyGuage =
+ new
HistogramDynamicMetric(PredefinedMetricDomains.DataPropagationLatencyGuage.name(),
+ new Histogram(new
SlidingTimeWindowArrayReservoir(getResetIntervalInMs(),
+ TimeUnit.MILLISECONDS)));
Review comment:
Could we add an inline comment saying this is deprecated and keeping it for
backward-compatibility purposes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
