jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r337791937
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -390,6 +404,9 @@ private void
refreshBaseline(ResourceControllerDataProvider clusterData,
Map<String, ResourceAssignment> newAssignment =
calculateAssignment(clusterData, clusterChanges,
resourceMap, activeNodes, currentBaseline,
currentBestPossibleAssignment);
+ // Measure BaselineDivergenceGauge.
+ measureBaselineDivergenceGauge(currentBaseline, newAssignment);
Review comment:
If the new best possible calculate fails, you will still need to report the
divergence between the new baseline and the old "previous" best possible state.
So maybe you need to calculate whenever a new baseline created or a new best
possible assignment created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
