narendly commented on a change in pull request #520: Refactoring soft constraints to simply the algorithm and fix potential issues. URL: https://github.com/apache/helix/pull/520#discussion_r337824491
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/PartitionMovementConstraint.java ########## @@ -44,8 +44,6 @@ // This factor indicates the default score that is evaluated if only partition allocation matches // (states are different). Review comment: Let's revise this description. Confusing - partition allocation matches what? states are different -> do you mean states are not factored in this calculation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
