jiajunwang commented on issue #519: Refine the rebalance scope calculating logic in the WAGED rebalancer. URL: https://github.com/apache/helix/pull/519#issuecomment-545335649 > I know this is nitpicky, but it really helps if I know what's going on clearly :) @narendly No worry, nitpicky is totally fine. However, I do wish that we can focus more on code logic. For example, in the "trimmedIdealState" part, it was problematic that I only trimmed for FULL_AUTO mode only, but not SEMI_AUTO. When you said this should be generic, it reminded me. But it would be even better if you, as the reviewer, can find these problems. There could be more, you know : ) Again, I think your comments are good ones. And thanks for reviewing in detail.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
