jiajunwang commented on a change in pull request #525: Add waged rebalancer
monitoring mbean metrics
URL: https://github.com/apache/helix/pull/525#discussion_r338728973
##########
File path:
helix-core/src/main/java/org/apache/helix/monitoring/metrics/model/Metric.java
##########
@@ -24,7 +24,7 @@
/**
* Defines a generic metric interface.
*/
-public interface Metric {
+public interface Metric<T> {
Review comment:
Let's comment the T is the input data, not necessary to be the output type
of the metric object.
For example, Histogram based metrics emits float or double.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
