i3wangyi commented on a change in pull request #519: Refine the rebalance scope
calculating logic in the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/519#discussion_r339195695
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/changedetector/ResourceChangeDetector.java
##########
@@ -50,8 +51,13 @@
private Map<HelixConstants.ChangeType, Collection<String>> _addedItems = new
HashMap<>();
private Map<HelixConstants.ChangeType, Collection<String>> _removedItems =
new HashMap<>();
- public ResourceChangeDetector() {
+ public ResourceChangeDetector(boolean ignoreHelixSourceChange) {
_newSnapshot = new ResourceChangeSnapshot();
+ _ignoreHelixSourceChange = ignoreHelixSourceChange;
+ }
+
+ public ResourceChangeDetector() {
Review comment:
Don't need the constructor. Just set a default value of false in the
`private final boolean _ignoreHelixSourceChange = false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
