narendly commented on a change in pull request #534: Draft proposal of method
signature for ZK custom serializer
URL: https://github.com/apache/helix/pull/534#discussion_r340401039
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
##########
@@ -326,6 +327,21 @@ public T get(String path, Stat stat, int options) {
return data;
}
+ public <K> K get(String path, Stat stat, int options, GenericSerializer<K>
serializer) {
+ //TODO
+ return null;
+ }
+
+ public <K> boolean create(String path, Stat stat, int options,
GenericSerializer<K> serializer) {
+ //TODO
+ return false;
+ }
+
+ public <K> boolean set(String path, Stat stat, int options,
GenericSerializer<K> serializer) {
+ //TODO
+ return false;
+ }
Review comment:
Since both PathBasedZkSerializer and ZkSerializer just use Java's generic
Object and byte array, we do not need to introduce another generic type K. So
it should look like the following:
`public Object get(String path, Stat stat, int options, ZkSerializer (or
PathBasedZkSerializer) customSerializer);`
Also, let us split the PR so that we have separate PRs for each public
method if you think that's easier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
