narendly commented on a change in pull request #558: New module hosting Helix
Zookeeper access logic
URL: https://github.com/apache/helix/pull/558#discussion_r349832536
##########
File path:
helix-zk/src/main/java/org/apache/helix/zkscale/zk/client/HelixZkClientFactory.java
##########
@@ -0,0 +1,48 @@
+package org.apache.helix.zkscale.zk.client;
+
+import org.I0Itec.zkclient.IZkConnection;
+//import org.apache.helix.HelixException;
+import org.apache.helix.zkscale.zk.ZkScaleException;
+import org.apache.helix.zkscale.zk.zookeeper.ZkConnection;
+
+/**
+ * Abstract class of the ZkClient factory.
+ */
+abstract class HelixZkClientFactory {
Review comment:
Is this supposed to be public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
