narendly commented on a change in pull request #624: Stabilize 5 unstable tests
URL: https://github.com/apache/helix/pull/624#discussion_r350500034
##########
File path: helix-core/src/test/java/org/apache/helix/integration/TestDrop.java
##########
@@ -55,16 +55,26 @@
* @param participants
*/
private void assertEmptyCSandEV(String clusterName, String db,
- MockParticipantManager[] participants) {
+ MockParticipantManager[] participants) throws Exception {
HelixDataAccessor accessor =
new ZKHelixDataAccessor(clusterName, new
ZkBaseDataAccessor<>(_gZkClient));
PropertyKey.Builder keyBuilder = accessor.keyBuilder();
- Assert.assertNull(accessor.getProperty(keyBuilder.externalView(db)));
+ boolean isExternalViewNull = TestHelper.verify(() -> {
+ ExternalView externalView =
accessor.getProperty(keyBuilder.externalView(db));
+ return (externalView == null);
+ }, TestHelper.WAIT_DURATION);
+ Assert.assertTrue(isExternalViewNull);
for (MockParticipantManager participant : participants) {
String instanceName = participant.getInstanceName();
String sessionId = participant.getSessionId();
-
Assert.assertNull(accessor.getProperty(keyBuilder.currentState(instanceName,
sessionId, db)));
+ boolean isCurrentStateNull = TestHelper.verify(() -> {
+ CurrentState currentState =
accessor.getProperty(keyBuilder.currentState(instanceName, sessionId, db));
+ return (currentState == null);
+ }, TestHelper.WAIT_DURATION);
+ Assert.assertTrue(isCurrentStateNull);
+
+
Review comment:
Redundant space?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
