jiajunwang commented on issue #632: Asynchronously calculating the Baseline URL: https://github.com/apache/helix/pull/632#issuecomment-559576361 > This is a preliminary review more on style and structuring the PR. I'd love to get to the async logic, but there seem to be a few things that should be sorted out before we jump deep into that.. > > Overall, I'd like to reiterate the point that we need to keep the PR size small and modular. I have demonstrated what could be separated into self-contained PRs. You will see the review go a lot faster and you will get better reviews. > > This way, we all win because reviewers will be happy to review the code for quality, and as a PR submitter, you'll see the review go a lot faster, and we all get a better quality algorithm/product. First of all, thanks for the review. I agree with you. This PR was not intended to be so large. But I find myself changing more and more while tests keep failing. Overall, the changes are all related. In other word, if we are not going to do async baseline calculation, all the additional change won't be necessary. To reduce overhead, I plan to re-organize the commits in this PR first. And then, if applicable, I will create additional PRs for the preparation commits. But those smaller changes won't have enough motivation if we review them separately. So I plan to just link those PRs to this one for the reviewers to understand the background.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
