narendly commented on a change in pull request #638: Decouple the event type
and the scheduled rebalance cache refresh option.
URL: https://github.com/apache/helix/pull/638#discussion_r352019394
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -240,8 +248,7 @@ public long getNextRebalanceTime() {
@Override
public void run() {
try {
- if (_clusterEventType.equals(ClusterEventType.PeriodicalRebalance) ||
_clusterEventType
- .equals(ClusterEventType.OnDemandRebalance)) {
+ if (_shouldRefreshCache) {
Review comment:
Is this a behavior change (since it could be risky in different parts of the
controller pipeline - as in it might refresh cache when it doesn't need to and
increase latency)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
