narendly commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r352428320
##########
File path:
helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/model/TestClusterModelProvider.java
##########
@@ -141,13 +143,14 @@ public void testGenerateClusterModel() throws
IOException {
.allMatch(replicaSet -> replicaSet.size() == 4));
// 3. test with no active instance
- clusterModel = ClusterModelProvider.generateClusterModel(testCache,
_resourceNames.stream()
+ clusterModel =
ClusterModelProvider.generateClusterModelForBaseline(testCache,
+ _resourceNames.stream()
.collect(Collectors.toMap(resource -> resource, resource -> new
Resource(resource))),
Collections.emptySet(), Collections.emptyMap(), Collections.emptyMap(),
Collections.emptyMap());
// Have only one instance
Assert.assertEquals(clusterModel.getAssignableNodes().size(), 0);
- // Shall have 0 assignable replicas because there is only n0 valid node.
+ // Shall have 0 assignable replicas because there is 0 valid node.
Review comment:
Nit: there are 0 valid (active/enabled) nodes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
