narendly commented on a change in pull request #589: Add CloudConfig operations
URL: https://github.com/apache/helix/pull/589#discussion_r352753271
##########
File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
##########
@@ -562,11 +563,33 @@ public ClusterConfig getClusterConfig(String
clusterName) {
return new ClusterConfig(record);
}
+
/**
- * Get RestConfig of the given cluster.
+ * Get CloudConfig of the given cluster.
*
- * @param clusterName The cluster
+ * @param clusterName
*
+ * @return The instance of {@link CloudConfig}
+ */
+ public CloudConfig getCloudConfig(String clusterName) {
+ if (!ZKUtil.isClusterSetup(clusterName, zkClient)) {
+ throw new HelixException("Failed to get config. cluster: " + clusterName
+ " is NOT setup.");
Review comment:
Nit: String.format where applicable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
