jiajunwang commented on a change in pull request #638: Decouple the event type
and the scheduled rebalance cache refresh option.
URL: https://github.com/apache/helix/pull/638#discussion_r352845728
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -240,8 +248,7 @@ public long getNextRebalanceTime() {
@Override
public void run() {
try {
- if (_clusterEventType.equals(ClusterEventType.PeriodicalRebalance) ||
_clusterEventType
- .equals(ClusterEventType.OnDemandRebalance)) {
+ if (_shouldRefreshCache) {
Review comment:
I tried to keep everything work as the old day. Logic only is changed if the
code is using the new methods.
Please let me know if you find any outliers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
