jiajunwang commented on issue #638: Decouple the event type and the scheduled rebalance cache refresh option. URL: https://github.com/apache/helix/pull/638#issuecomment-560586403 > I have a feeling that this should actually require more changes in other parts of the code since there are many places that use scheduledRebalance functionality. Is that true? If so, should we identify and review each use case? You are right, if anyone relies on, for example ClusterEventType.RetryRebalance, to trigger a rebalance without a cache refresh, the old application code will trigger unnecessary refresh with the new lib. An alternative way is that we add a optional config to the Rebalance Task. So that it takes effect when it's specified, or the logic will be kept the same. But that will make the code too complicated. I would prefer not doing that since guessing the refresh requirement based on the event type is not quite decent logic anyway. But I'm open to change. @lei-xia Could you please also comment here? Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
