pkuwm commented on a change in pull request #642: Fix zk session race condition
before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353011414
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -1099,8 +1098,14 @@ public void handleStateChanged(KeeperState state) {
@Override
public void handleNewSession() throws Exception {
Review comment:
I was hesitated to do so as there are other places using the api like
MockParticipantManager and ZkTestHelper. And also it is a public API. I thought
we could deprecate it after we change the usage in MockParticipantManager and
ZkTestHelper. That may bring in more changes in tests. Not sure whether or not
we want to do it in another PR. We can discuss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
