jiajunwang commented on a change in pull request #636: Simply and enhance the RebalanceLatencyGauge so it can be used in multi-threads. URL: https://github.com/apache/helix/pull/636#discussion_r353466561
########## File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/implementation/RebalanceLatencyGauge.java ########## @@ -30,6 +31,8 @@ private static final Logger LOG = LoggerFactory.getLogger(RebalanceLatencyGauge.class); private static final long VALUE_NOT_SET = -1; private long _lastEmittedMetricValue = VALUE_NOT_SET; + // Use threadlocal here so the start time can be updated and recorded in multi-threads. + private final ThreadLocal<Long> _startTime; Review comment: It is necessary because we don't want multiple gauge objects. That will require us to assign different sensor names to those metrics. That would be very hard to manage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
