i3wangyi commented on a change in pull request #638: Decouple the event type
and the scheduled rebalance cache refresh option.
URL: https://github.com/apache/helix/pull/638#discussion_r353516096
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -240,8 +249,11 @@ public long getNextRebalanceTime() {
@Override
public void run() {
try {
- if (_clusterEventType.equals(ClusterEventType.PeriodicalRebalance) ||
_clusterEventType
- .equals(ClusterEventType.OnDemandRebalance)) {
+ // If refresh option is specified, there is no need to check the event
type.
+ if ((!_shouldRefreshCache.isPresent() && (
Review comment:
It's hard to read the long if statement. You could use
`_shouldRefreshCache.orElse(false)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
