pkuwm opened a new pull request #644: Customize IZkStateListener to add handleNewSession(sessionId) URL: https://github.com/apache/helix/pull/644 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #643 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Current I0ITec IZkStateListener doesn't have an API handleNewSession(sessionId), which is needed for #642 To avoid creating a new stateListener extends IZkStateListener, it seems better to move IZkStateListener to helix internal. So we would have flexible control to add the new API. Changelist: 1. Copy I0Itec IZkStateListener to helix 2. Add new api handleNewSession(sessionId) to the interface IZkStateListener 3. Replace all I0Itec IZkStateListener class with the customized IZkStateListener. ### Tests - [ ] The following tests are written for this issue: (List the names of added unit/integration tests) - [x] The following is the result of the "mvn test" command on the appropriate module: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestJobQueueCleanUp.testJobQueueAutoCleanUp » ThreadTimeout Method org.testng.... [ERROR] TestTaskRebalancerStopResume.stopDeleteJobAndResumeNamedQueue:199 » Helix Fail... [INFO] [ERROR] Tests run: 887, Failures: 2, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:00 h [INFO] Finished at: 2019-12-04T12:38:29-08:00 [INFO] ------------------------------------------------------------------------ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.316 s - in org.apache.helix.integration.task.TestJobQueueCleanUp [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.841 s - in org.apache.helix.integration.task.TestTaskRebalancerStopResume [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
