jiajunwang commented on a change in pull request #644: Customize 
IZkStateListener to add handleNewSession(sessionId)
URL: https://github.com/apache/helix/pull/644#discussion_r354594493
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
 ##########
 @@ -279,12 +278,50 @@ public void subscribeStateChanges(final IZkStateListener 
listener) {
     }
   }
 
+  public void subscribeStateChanges(final org.I0Itec.zkclient.IZkStateListener 
listener) {
+    subscribeStateChanges(new IZkStateListener() {
 
 Review comment:
   Still duplicated code. Let's have a single wrapper implement class for the 
IOItech interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to